Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Moving predis to suggest#48

Merged
cryptiklemur merged 2 commits intomasterphp-cache/cache:masterfrom
aequasi-patch-1php-cache/cache:aequasi-patch-1Copy head branch name to clipboard
Apr 22, 2016
Merged

Moving predis to suggest#48
cryptiklemur merged 2 commits intomasterphp-cache/cache:masterfrom
aequasi-patch-1php-cache/cache:aequasi-patch-1Copy head branch name to clipboard

Conversation

@cryptiklemur
Copy link
Member

@cryptiklemur cryptiklemur commented Apr 22, 2016

Resolves #47

@codecov-io
Copy link

codecov-io commented Apr 22, 2016

Current coverage is 90.61%

Merging #48 into master will decrease coverage by -0.37% as of d7c89d2

@@            master     #48   diff @@
======================================
  Files           21      21       
  Stmts          765     799    +34
  Branches         0       0       
  Methods        189     192     +3
======================================
+ Hit            696     724    +28
  Partial          0       0       
- Missed          69      75     +6

Review entire Coverage Diff as of d7c89d2

Powered by Codecov. Updated on successful CI builds.

@cryptiklemur cryptiklemur merged commit d138d3f into master Apr 22, 2016
@cryptiklemur cryptiklemur deleted the aequasi-patch-1 branch April 22, 2016 16:35
@Nyholm Nyholm mentioned this pull request Apr 23, 2016
Closed
@Nyholm
Copy link
Member

Nyholm commented Apr 23, 2016

Why not move it to require-dev? It would be great if I could do composer update and then run all the tests. Predis has no requirement on PHP extensions like monogdb has.

@cryptiklemur
Copy link
Member Author

cryptiklemur commented Apr 23, 2016

True, I can change it to that. Its still running all the tests fine though

@Nyholm
Copy link
Member

Nyholm commented Apr 23, 2016

Please do. It works fine on Travis but not on my local environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cryptiklemur @codecov-io @Nyholm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.