Move predis/predis to suggestions#47
Closed
Sleavely wants to merge 2 commits intophp-cache:masterphp-cache/cache:masterfrom
Closed
Move predis/predis to suggestions#47Sleavely wants to merge 2 commits intophp-cache:masterphp-cache/cache:masterfrom
Sleavely wants to merge 2 commits intophp-cache:masterphp-cache/cache:masterfrom
Conversation
Author
|
The test for |
Merged
Member
|
Thank you for this PR. As you probably noticed @aequasi helped you solve this issue in #48. Btw, I see that you are based in Stockholm. Will I see you at the next PHP meetup? |
Author
|
Yeah I saw. Thanks! Not sure; I'm horrible at networking and might be out of the country that week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to breakage when combined with Laravel 4 and below (L4 imposes predis 0.8.7 restriction) I moved predis/predis to suggest-section of composer.json.
If my changes turn out to break Travis I'll just close the PR and go cry in the corner.