Removed pure zpp tests in the imap extension.#5569
Closed
jensdenies wants to merge 1 commit into
Closed
Conversation
Girgias
approved these changes
May 13, 2020
nikic
approved these changes
May 14, 2020
Member
nikic
left a comment
There was a problem hiding this comment.
It looks like all of those would fail on PHP 8 as well, because they check warnings rather than exceptions. We really need ext/imap on CI...
Contributor
Author
|
@nikic there are still some warnings left in test files in imap which are not purely zpp tests. I didn't remove those because i have no way of running these tests and thus i can't verify if they still work after my changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across pull request #3794 and #3783 and noticed that pure zpp tests are removed. I noticed there were still some tests left in the imap extension and therefore i created this pull request to remove them.
I ran the tests locally, but most of them were skipped because i don't have a local imap server running. Two tests also seemed to fail but i don't think that has to do with the deletions made in this pull request.