Define Stringable with toString():string method#5088
Closed
nicolas-grekas wants to merge 1 commit into
php:masterphp/php-src:masterfrom
nicolas-grekas:stringable-regular-methodnicolas-grekas/php-src:stringable-regular-methodCopy head branch name to clipboard
Closed
Define Stringable with toString():string method#5088nicolas-grekas wants to merge 1 commit intophp:masterphp/php-src:masterfrom nicolas-grekas:stringable-regular-methodnicolas-grekas/php-src:stringable-regular-methodCopy head branch name to clipboard
nicolas-grekas wants to merge 1 commit into
php:masterphp/php-src:masterfrom
nicolas-grekas:stringable-regular-methodnicolas-grekas/php-src:stringable-regular-methodCopy head branch name to clipboard
Conversation
|
@nicolas-grekas I appriciate the effort you put in this PR. Thank you. I would like to be able to add a public API to the object for mapping to the string without losing the advantage of internal coherence in string functions but I see the issue with duplicates of code for BC. So yeah, if this does not fit the PHP development path then further discussion on this topic is not worth it. Again, thank you for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is opened for the purpose of comparison with #5083
It adds a new interface:
Implementing this interface triggers the same magic behavior as implementing
__toString().Compared to #5083, the new method has no double underscore as a prefix, which means it can more easily be used as part of public APIs.
Yet, it requires a more invasive change in the engine, and leads to duplicate
__toString()andtoString()methods for BC. Since adding a method namedtoString()can be done purely in userland, it appears that this approach might not be the preferred one for php-internals, which seeks for the lesser complexity.