Remove (binary) casts from phar stub#2190
Closed
kelunik wants to merge 1 commit into
Closed
Remove (binary) casts from phar stub#2190kelunik wants to merge 1 commit into
kelunik wants to merge 1 commit into
Conversation
Member
Author
|
Closing, there's a separate commit in the mentioned PR that is complete: 33dbcea |
Member
Member
|
@kelunik can we have this branch back please ? I'm happy to merge this one change, it is all that is required to ease forward compat ... we don't need all those test changes to achieve the same thing, I'm more reluctant to commit those. |
Member
Author
|
@krakjoe: We need to adjust the tests that check for the length, too. See the linked commit, I think you can just cherry pick that one. |
Member
|
Oh I see, got it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if #2187 doesn't get merged (now), there's no reason to use (binary) as PHP 6 forward compatibility is not a concern anymore.