Test Round: Added tests to check operation with existing implementation#13399
Merged
Girgias merged 1 commit intoFeb 17, 2024
php:masterphp/php-src:masterfrom
SakiTakamachi:feature/expand-rounding-target-testSakiTakamachi/php-src:feature/expand-rounding-target-testCopy head branch name to clipboard
Merged
Test Round: Added tests to check operation with existing implementation#13399Girgias merged 1 commit intophp:masterphp/php-src:masterfrom SakiTakamachi:feature/expand-rounding-target-testSakiTakamachi/php-src:feature/expand-rounding-target-testCopy head branch name to clipboard
Girgias merged 1 commit into
php:masterphp/php-src:masterfrom
SakiTakamachi:feature/expand-rounding-target-testSakiTakamachi/php-src:feature/expand-rounding-target-testCopy head branch name to clipboard
Conversation
Member
|
I didn't mean to say to create a new PR to add the tests, but just to split your existing PR into two commits :) But this is fine too :) |
Member
Author
|
I see, I misunderstood. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #12222