Binary string deprecation#188
Closed
pmmaga wants to merge 2 commits into
php:masterphp/php-langspec:masterfrom
pmmaga:binary-string-deprecationpmmaga/php-langspec:binary-string-deprecationCopy head branch name to clipboard
Closed
Binary string deprecation#188pmmaga wants to merge 2 commits intophp:masterphp/php-langspec:masterfrom pmmaga:binary-string-deprecationpmmaga/php-langspec:binary-string-deprecationCopy head branch name to clipboard
pmmaga wants to merge 2 commits into
php:masterphp/php-langspec:masterfrom
pmmaga:binary-string-deprecationpmmaga/php-langspec:binary-string-deprecationCopy head branch name to clipboard
Conversation
Contributor
|
Keep in mind that the RFC has not been voted yet. Must not merge this PR yet. |
Contributor
|
And thanks for the PR :-). |
Member
|
As the actual removal will only happen in PHP 8, shouldn't this patch only specify deprecation? |
Contributor
Author
|
Sure, I can change it to mention the deprecation on the text files then. About the test, should I keep it there as well then? |
15f1910 to
50f65a1
Compare
50f65a1 to
4bd6003
Compare
Contributor
Author
|
I've updated the PR to reflect the deprecation phase. |
Contributor
Author
|
Closing as the RFC was rejected |
|
@pmmaga Do you know why this RFC was rejected? And, it can be deprecated in PHP 8? Thanks. |
Contributor
Author
|
@padrecedano you can find the discussion here and more here The RFC itself is found here. Given the rejection, it is very unlikely it will get deprecated any time soon. |
|
@pmmaga thanks for the fast response and for the discussion links! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the Binary string deprecation RFC.
The PR for php-src can be found here