@kdeldycke I think we should leave test file names as is. The normal convention is test_module_name.py but since we are testing by function or class we should use test_ExactName.py. Then it is very clear what our structure is.

@kdeldycke I think we should leave test file names as is. The normal convention is test_module_name.py but since we are testing by function or class we should use test_ExactName.py. Then it is very clear what our structure is.

test_CamelCase.py and test__private_function.py looks ugly to me, so let's ask @davidism to make a call on that naming convention, and I will apply it! 😅 My own rationale is it introduce less surprises when invoking pytest with wildcards like pytest "tests/test_stuff_*".

@Rowlando13 @davidism , unless there is something big I uncover in the next few days, this is my last PR for the 8.5.0 release. After this if you think it is ready, we can think about releasing 8.5.0. What do you think?

Okay. I think 8.5.0 is about the right size. The only thing left I want to do is move all the tests into separate files so when we merge main to stable it will be done.

If we can leave the renaming of test files alone, I will merge this so we are all ready as splitting test files does not need a change log.

If we can leave the renaming of test files alone, I will merge this so we are all ready as splitting test files does not need a change log.

I just reverted the test filenames to your original version in https://github.com/pallets/click/compare/4a735fa183dbc44b6d4c89e26b946a432ed7df58..0f4738df88e3ea47c40a4a442103596a61cfee79 . There is no point to delay the work on 8.5.0 for this kind of bikesheding.

Feel free to merge! :)