This repository was archived by the owner on Dec 1, 2023. It is now read-only.
Fix async and defer options when loading scripts#737
Open
dawid-in wants to merge 1 commit into
Open
Fix async and defer options when loading scripts#737dawid-in wants to merge 1 commit into
dawid-in wants to merge 1 commit into
Conversation
Contributor
|
Hi @dawid-in Could you please tell us a bit more about your pull request? I think it's still possible to use async and defer, using something like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Options are stored as value in the array, rather than a key.
[x] I have read and followed the contribution guide: https://github.com/pagekit/pagekit/blob/develop/.github/CONTRIBUTING.md
[x] The destination branch of the pull request is the develop branch