Use message name instead of self#85
Merged
killercup merged 1 commit intoAug 28, 2024
oxibus:mainoxibus/dbc-codegen:mainfrom
inomotech-foss:fix-mux-msg-idinomotech-foss/dbc-codegen:fix-mux-msg-idCopy head branch name to clipboard
Merged
Use message name instead of self#85killercup merged 1 commit intooxibus:mainoxibus/dbc-codegen:mainfrom inomotech-foss:fix-mux-msg-idinomotech-foss/dbc-codegen:fix-mux-msg-idCopy head branch name to clipboard
killercup merged 1 commit into
oxibus:mainoxibus/dbc-codegen:mainfrom
inomotech-foss:fix-mux-msg-idinomotech-foss/dbc-codegen:fix-mux-msg-idCopy head branch name to clipboard
Conversation
killercup
approved these changes
Aug 28, 2024
Contributor
|
Would be awesome to have a test for this in a follow-up :) |
Contributor
Author
I really wanted to but it didn't seem like the repository is currently well equipped to easily add such tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated code for multiplexed messages is currently invalid because
Selfdoesn't point to the message type in those cases and doesn't have aMESSAGE_ID