Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Use unique metric name for HTTP requests#702

Merged
jonesbusy merged 1 commit into
oras-project:mainoras-project/oras-java:mainfrom
jonesbusy:feature/unique-metricjonesbusy/oras-java:feature/unique-metricCopy head branch name to clipboard
May 11, 2026
Merged

Use unique metric name for HTTP requests#702
jonesbusy merged 1 commit into
oras-project:mainoras-project/oras-java:mainfrom
jonesbusy:feature/unique-metricjonesbusy/oras-java:feature/unique-metricCopy head branch name to clipboard

Conversation

@jonesbusy
Copy link
Copy Markdown
Collaborator

@jonesbusy jonesbusy commented May 11, 2026

Conflict with Quarkus for example

java.lang.IllegalArgumentException: Prometheus requires that all meters with the same name have the  │
│ same set of tag keys. There is already an existing meter named 'http_client_requests_seconds' containing tag keys [clientName, method, outcome, status, uri]. The meter you are attempting to register has ke │
│ ys [host, method, status].

Description

Testing done

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@jonesbusy jonesbusy added the bug Something isn't working label May 11, 2026
@jonesbusy
Use unique metric name for HTTP requests
48097f7 
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@jonesbusy jonesbusy force-pushed the feature/unique-metric branch from d6721cd to 48097f7 Compare May 11, 2026 12:01
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.39%. Comparing base (9d7d1c7) to head (48097f7).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #702      +/-   ##
============================================
+ Coverage     86.85%   87.39%   +0.53%     
  Complexity      965      965              
============================================
  Files            44       44              
  Lines          3006     3006              
  Branches        377      377              
============================================
+ Hits           2611     2627      +16     
+ Misses          233      217      -16     
  Partials        162      162

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy merged commit 903b273 into oras-project:main May 11, 2026
11 of 14 checks passed
@jonesbusy jonesbusy deleted the feature/unique-metric branch May 11, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonesbusy
Morty Proxy This is a proxified and sanitized view of the page, visit original site.