Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: remove deprecated positional-arg compatibility from study and trial APIs#6747

Open
yen-0 wants to merge 4 commits into
optuna:masteroptuna/optuna:masterfrom
yen-0:testyen-0/optuna-test:testCopy head branch name to clipboard
Open

fix: remove deprecated positional-arg compatibility from study and trial APIs#6747
yen-0 wants to merge 4 commits into
optuna:masteroptuna/optuna:masterfrom
yen-0:testyen-0/optuna-test:testCopy head branch name to clipboard

Conversation

@yen-0

@yen-0 yen-0 commented Jul 8, 2026

Copy link
Copy Markdown

Motivation

Delete convert_positional_args and warnings to prepare for 5.0.0.

Description of the changes

Deleted decorators for converting positional args and the imports for them in the following functions:

study/study.py  -- create_study, load_study, delete_study
trial/_fixed.py  -- suggest_int
trial/_frozen.py  -- suggest_int
trial/_trial.py  -- suggest_int

@yen-0
yen-0 marked this pull request as draft July 8, 2026 07:30
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

This pull request has not seen any recent activity.

@github-actions github-actions Bot added the stale Exempt from stale bot labeling. label Jul 15, 2026
@c-bata c-bata removed the stale Exempt from stale bot labeling. label Jul 16, 2026
@c-bata c-bata added the compatibility Change that breaks compatibility. label Jul 17, 2026
@c-bata c-bata added this to the v5.0.0 milestone Jul 17, 2026
@yen-0
yen-0 marked this pull request as ready for review July 17, 2026 09:33
c-bata
c-bata approved these changes Jul 17, 2026
View reviewed changes

@c-bata c-bata left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata

c-bata commented Jul 21, 2026

Copy link
Copy Markdown
Member

@y0z Could you review this PR?

y0z
y0z reviewed Jul 24, 2026
View reviewed changes
Comment thread optuna/trial/_fixed.py
from optuna.distributions import FloatDistribution
from optuna.distributions import IntDistribution
from optuna.study._constrained_optimization import _CONSTRAINTS_KEY
from optuna.trial._base import _SUGGEST_INT_POSITIONAL_ARGS

@y0z y0z Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think _SUGGEST_INT_POSITIONAL_ARGS can be removed since no longer used anywhere.

optuna/optuna/trial/_base.py

Line 19 in 7865149

_SUGGEST_INT_POSITIONAL_ARGS = ["self", "name", "low", "high", "step", "log"]

y0z
y0z reviewed Jul 24, 2026
View reviewed changes

@y0z y0z left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM with a minor comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@y0z y0z y0z left review comments
@c-bata c-bata c-bata approved these changes

Assignees

@y0z y0z

Labels

compatibility Change that breaks compatibility.

Projects

None yet

Milestone

v5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@yen-0 @c-bata @y0z
Morty Proxy This is a proxified and sanitized view of the page, visit original site.