Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: suppress PHP 8.4 ArrayAccess deprecations#9

Open
savinmikhail wants to merge 1 commit into
opis:masteropis/string:masterfrom
savinmikhail:fix/php84-arrayaccess-deprecationssavinmikhail/string:fix/php84-arrayaccess-deprecationsCopy head branch name to clipboard
Open

fix: suppress PHP 8.4 ArrayAccess deprecations#9
savinmikhail wants to merge 1 commit into
opis:masteropis/string:masterfrom
savinmikhail:fix/php84-arrayaccess-deprecationssavinmikhail/string:fix/php84-arrayaccess-deprecationsCopy head branch name to clipboard

Conversation

@savinmikhail
Copy link
Copy Markdown

@savinmikhail savinmikhail commented Apr 24, 2026

Fixes #8

Summary

  • add explicit @return void annotations to UnicodeString::offsetSet() and UnicodeString::offsetUnset()
  • keep #[\ReturnTypeWillChange] in place for compatibility with supported PHP versions

Notes

  • this avoids PHP 8.4 deprecation noise around ArrayAccess method signatures without requiring native return types
  • full dependency installation was not completed locally because the host PHP is missing ext-dom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHP 8.4 deprecation: UnicodeString ArrayAccess methods are missing void return types

1 participant

@savinmikhail
Morty Proxy This is a proxified and sanitized view of the page, visit original site.