Add compat/__init__.py#82
Add compat/__init__.py#82dwhswenson merged 1 commit intoopenpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom dwhswenson:add-compat-initdwhswenson/openpathsampling-cli:add-compat-initCopy head branch name to clipboard
Conversation
Somehow I forgot to add this in git; had it in local checkout.
|
This is ready for review and comment. Without review, I will merge this after at least 12 hours, no sooner than Thu 08 Aug 18:00 GMT (13:00 my local). I'll follow that quickly with a PR to do a 0.3.1 patch release. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 5422 5422
=========================================
Hits 5422 5422 ☔ View full report in Codecov by Sentry. |
sroet
left a comment
There was a problem hiding this comment.
LGTM, bit surprised it passed tests without it
|
I think the issue here is that we don't do the all-optionals test when we do release testing. So we didn't trigger the code to import OpenMM (which is what this is about). FWIW, we can also simplify the OpenMM code in there. Treating OpenMM with the rules of either SPEC0 or NEP29, we no longer need to support OpenMM 7.5. |
Somehow I forgot to add this in git; had it in local checkout.