Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

SPEC0/NEP29: Add Python 3.12, drop Python 3.9#78

Merged
dwhswenson merged 2 commits into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:py312dwhswenson/openpathsampling-cli:py312Copy head branch name to clipboard
Jun 11, 2024
Merged

SPEC0/NEP29: Add Python 3.12, drop Python 3.9#78
dwhswenson merged 2 commits into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:py312dwhswenson/openpathsampling-cli:py312Copy head branch name to clipboard

Conversation

@dwhswenson

Copy link
Copy Markdown
Member

Both SPEC0 and NEP29 currently recommend supporting Python versions 3.10, 3.11, and 3.12. Tests here hadn't started on 3.12 and still tested 3.9. This PR just changes the testing matrix.

@dwhswenson dwhswenson added ci Improvements to continuous integration misc PR labels Jun 9, 2024
@codecov

codecov Bot commented Jun 9, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5dc52b5) to head (7ec200a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         5420      5418    -2     
=========================================
- Hits          5420      5418    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwhswenson

Copy link
Copy Markdown
Member Author

Also required fixing an error that apparently was silently passing in a misuse of mock until Python 3.12? (Or maybe based on older versions of mock?)

This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Tue 11 Jun 01:00 GMT (Mon 10 Jun 20:00 my local).

@sroet sroet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwhswenson dwhswenson merged commit 4a9f55c into openpathsampling:main Jun 11, 2024
@dwhswenson dwhswenson deleted the py312 branch June 11, 2024 01:48
@dwhswenson dwhswenson mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Improvements to continuous integration misc PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.