Silence annoying pymbar warnings#77
Merged
dwhswenson merged 2 commits intoJun 11, 2024
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:silence-pymbardwhswenson/openpathsampling-cli:silence-pymbarCopy head branch name to clipboard
Merged
Silence annoying pymbar warnings#77dwhswenson merged 2 commits intoopenpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom dwhswenson:silence-pymbardwhswenson/openpathsampling-cli:silence-pymbarCopy head branch name to clipboard
dwhswenson merged 2 commits into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:silence-pymbardwhswenson/openpathsampling-cli:silence-pymbarCopy head branch name to clipboard
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 5416 5422 +6
=========================================
+ Hits 5416 5422 +6 ☔ View full report in Codecov by Sentry. |
Member
Author
|
This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Tue 11 Jun 00:00 GMT (Mon 10 Jun 19:00 my local). |
sroet
approved these changes
Jun 10, 2024
sroet
left a comment
Member
There was a problem hiding this comment.
LGTM.
I would add a TODO to mention that this should be removed once openmmtools is fixed. Feel free to ignore ;)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On importing OpenMMTools (which happens as part of reloading objects), we get some annoying warnings from pymbar. I'd like to try to get this fixed upstream in OpenMMTools, but for now here's a hack that makes it less unpleasant to work with the CLI.