Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix CI problems#74

Merged
dwhswenson merged 3 commits into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:back-to-greendwhswenson/openpathsampling-cli:back-to-greenCopy head branch name to clipboard
Apr 23, 2024
Merged

Fix CI problems#74
dwhswenson merged 3 commits into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:back-to-greendwhswenson/openpathsampling-cli:back-to-greenCopy head branch name to clipboard

Conversation

@dwhswenson

@dwhswenson dwhswenson commented Apr 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Problems with CI that this will fix:

  1. We're way behind on Python versions; this brings the CLI in line with versions tested in the OPS library
  2. We're having a problem with the build process; seems something was problematic with the pip install stack (I think this was fixed by not trying to support older Pythons)
  3. Tests needed to be updated from setup/teardown to setup_method/teardown_method
  4. Updated CodeCov, as it didn't seem to allow uploads without token.

This wasn't as bad as I feared!

@dwhswenson dwhswenson added ci Improvements to continuous integration misc PR labels Apr 23, 2024
@dwhswenson

dwhswenson commented Apr 23, 2024

Copy link
Copy Markdown
Member Author

This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Wed 24 Apr 17:00 GMT (12:00 my local).

@codecov

codecov Bot commented Apr 23, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b430d8b) to head (e7f4149).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         5416      5416           
=========================================
  Hits          5416      5416

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sroet
sroet approved these changes Apr 23, 2024
View reviewed changes

@sroet sroet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwhswenson dwhswenson merged commit ccd7c30 into openpathsampling:main Apr 23, 2024
@dwhswenson dwhswenson deleted the back-to-green branch April 23, 2024 16:50
@dwhswenson dwhswenson mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sroet sroet sroet approved these changes

Assignees

No one assigned

Labels

ci Improvements to continuous integration misc PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dwhswenson @sroet
Morty Proxy This is a proxified and sanitized view of the page, visit original site.