Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Wizard: Fix uncaught exception if user input is empty#65

Merged
dwhswenson merged 1 commit into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:wizard-empty-inputdwhswenson/openpathsampling-cli:wizard-empty-inputCopy head branch name to clipboard
Nov 2, 2021
Merged

Wizard: Fix uncaught exception if user input is empty#65
dwhswenson merged 1 commit into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:wizard-empty-inputdwhswenson/openpathsampling-cli:wizard-empty-inputCopy head branch name to clipboard

Conversation

@dwhswenson

Copy link
Copy Markdown
Member

Previously, if the user input was the empty string, the code checking for help/command (looking are user_input[0] would error out. This prevents that error from occurring.

@dwhswenson dwhswenson added the bug Something isn't working label Nov 2, 2021
@dwhswenson dwhswenson changed the title Wizard: Fix uncaught exception if user input to empty Wizard: Fix uncaught exception if user input is empty Nov 2, 2021
@codecov

codecov Bot commented Nov 2, 2021

Copy link
Copy Markdown

Codecov Report

Merging #65 (d11d7bc) into main (34cf3a0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           51        51           
  Lines         2143      2147    +4     
=========================================
+ Hits          2143      2147    +4     
Impacted Files Coverage Δ
paths_cli/wizard/wizard.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34cf3a0...d11d7bc. Read the comment docs.

@sroet sroet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwhswenson dwhswenson merged commit 0226749 into openpathsampling:main Nov 2, 2021
@dwhswenson dwhswenson deleted the wizard-empty-input branch November 2, 2021 17:12
@dwhswenson dwhswenson mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.