Preserve plugin load order with OrderedSet#60
Merged
dwhswenson merged 3 commits intoOct 31, 2021
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:plugins-ordered-setdwhswenson/openpathsampling-cli:plugins-ordered-setCopy head branch name to clipboard
Merged
Preserve plugin load order with OrderedSet#60dwhswenson merged 3 commits intoopenpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom dwhswenson:plugins-ordered-setdwhswenson/openpathsampling-cli:plugins-ordered-setCopy head branch name to clipboard
OrderedSet#60dwhswenson merged 3 commits into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:plugins-ordered-setdwhswenson/openpathsampling-cli:plugins-ordered-setCopy head branch name to clipboard
Conversation
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 45 51 +6
Lines 1766 2136 +370
==========================================
+ Hits 1766 2136 +370
Continue to review full report at Codecov.
|
sroet
approved these changes
Oct 31, 2021
sroet
left a comment
Member
There was a problem hiding this comment.
I am a bit paranoid about the current not in test, otherwise LGTM
Co-authored-by: Sander Roet <sanderroet@hotmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #57, the Wizard would benefit from plugins always loading in the same order. Without this, the order of category plugins located in the same file tended to be random. For example, the choices of CV types (Distance, Angle, Dihedral, etc) were not consistent between different runs of the wizard. This also seemed to be the case with command plugins: the order they were listed in
--helpwas not retained.Here I replace the
setused previously with a custom-writtenOrderedSetclass. This seems to have fixed these consistency issues.