Wizard improvements: more help; improvements loading from OPS files#58
Merged
dwhswenson merged 4 commits intoNov 1, 2021
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:wizard-extra-helpdwhswenson/openpathsampling-cli:wizard-extra-helpCopy head branch name to clipboard
Merged
Wizard improvements: more help; improvements loading from OPS files#58dwhswenson merged 4 commits intoopenpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom dwhswenson:wizard-extra-helpdwhswenson/openpathsampling-cli:wizard-extra-helpCopy head branch name to clipboard
dwhswenson merged 4 commits into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:wizard-extra-helpdwhswenson/openpathsampling-cli:wizard-extra-helpCopy head branch name to clipboard
Conversation
- Add help for `n_frames_max` - Add help for volume category - Add help for Union, Intersection, and Complement volumes - Add LoadFromOPSFile to volumes
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 2113 2107 -6
=========================================
- Hits 2113 2107 -6
Continue to review full report at Codecov.
|
sroet
requested changes
Oct 31, 2021
sroet
left a comment
Member
There was a problem hiding this comment.
1 possible uncaught error and a documentation suggestion
sroet
approved these changes
Nov 1, 2021
sroet
left a comment
Member
There was a problem hiding this comment.
All my comments have been resolved, LGTM
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses several of the issues listed in #57 that are targeted for the v0.3 release:
n_frames_maxHelperto parse input when selecting objects from OPS file (allow commands)This includes #54, so it will be easier to review after that has been merged.