Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix CodeCov action#56

Merged
dwhswenson merged 1 commit into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:codecov-fixdwhswenson/openpathsampling-cli:codecov-fixCopy head branch name to clipboard
Oct 8, 2021
Merged

Fix CodeCov action#56
dwhswenson merged 1 commit into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:codecov-fixdwhswenson/openpathsampling-cli:codecov-fixCopy head branch name to clipboard

Conversation

@dwhswenson

Copy link
Copy Markdown
Member

It looks like since #53 we haven't actually been successfully uploading coverage. I'll try to fix that here.

@dwhswenson dwhswenson added ci Improvements to continuous integration misc PR labels Oct 8, 2021
@codecov

codecov Bot commented Oct 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #56 (da866bf) into main (8f6a797) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #56   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         1766      1766           
=========================================
  Hits          1766      1766           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ee0a2...da866bf. Read the comment docs.

@dwhswenson

Copy link
Copy Markdown
Member Author

Looks like this fixed it! Will consider this ready to merge immediately after review, or if no review, after 12 hours from now (no earlier than Fri 08 Oct 19:00 GMT (15:00 my local)) -- after I get some sleep.

@sroet sroet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for not catching that earlier

@dwhswenson dwhswenson merged commit f8ed965 into openpathsampling:main Oct 8, 2021
@dwhswenson dwhswenson deleted the codecov-fix branch October 8, 2021 17:35
@dwhswenson dwhswenson mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Improvements to continuous integration misc PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.