Updates for OpenMM 7.6#50
Updates for OpenMM 7.6#50dwhswenson merged 3 commits intoopenpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom dwhswenson:fix-openmm-simtk-urldwhswenson/openpathsampling-cli:fix-openmm-simtk-urlCopy head branch name to clipboard
Conversation
Codecov Report
@@ Coverage Diff @@
## main #50 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 1202 1204 +2
=========================================
+ Hits 1202 1204 +2
Continue to review full report at Codecov.
|
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Fri 03 Sep 01:00 GMT (Thu 02 Sep 21:00 my local). |
sroet
left a comment
There was a problem hiding this comment.
A couple left over old code and missing reasons for skips. I am not too happy about the code duplication on the test files (around the imports), but this is easier to understand than indirect imports, so no favor one way or another (As long as it exists in just 2 files)
|
Made changes, though not quite the ones you suggested. I intentionally left the commented |
Most significantly, this fixes a test error on the URL that @sroet suggested I add a test for (thanks @sroet!) by removing the
simtkfrom the URL. I also went ahead and made it so we preferred new 7.6-style imports everywhere else.