Fix tests for moved CVs in OPS 1.5#46
Merged
dwhswenson merged 1 commit intoJul 7, 2021
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:fix-tests-ops-1.5dwhswenson/openpathsampling-cli:fix-tests-ops-1.5Copy head branch name to clipboard
Merged
Fix tests for moved CVs in OPS 1.5#46dwhswenson merged 1 commit intoopenpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom dwhswenson:fix-tests-ops-1.5dwhswenson/openpathsampling-cli:fix-tests-ops-1.5Copy head branch name to clipboard
dwhswenson merged 1 commit into
openpathsampling:mainopenpathsampling/openpathsampling-cli:mainfrom
dwhswenson:fix-tests-ops-1.5dwhswenson/openpathsampling-cli:fix-tests-ops-1.5Copy head branch name to clipboard
Conversation
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 599 599
=========================================
Hits 599 599 Continue to review full report at Codecov.
|
Member
Author
|
Fixes tests. Merging. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes related to CVs being imported at
openpathsampling.collectivevariablesinstead of.collectivevariablemeant that if you patch and unpatch to support SimStore, you get the same base classes defined at two different memory addresses, which caused non-obvious problems when callingsuper. This PR fixes.This is only an issue for situations like unit tests, where it is necessary to unpatch for SimStore after patching.