SimStore: Simplify OPS Storage constructor#950
Merged
dwhswenson merged 2 commits intoDec 23, 2020
openpathsampling:masteropenpathsampling/openpathsampling:masterfrom
dwhswenson:simstore-simplifydwhswenson/openpathsampling:simstore-simplifyCopy head branch name to clipboard
Merged
SimStore: Simplify OPS Storage constructor#950dwhswenson merged 2 commits intoopenpathsampling:masteropenpathsampling/openpathsampling:masterfrom dwhswenson:simstore-simplifydwhswenson/openpathsampling:simstore-simplifyCopy head branch name to clipboard
dwhswenson merged 2 commits into
openpathsampling:masteropenpathsampling/openpathsampling:masterfrom
dwhswenson:simstore-simplifydwhswenson/openpathsampling:simstore-simplifyCopy head branch name to clipboard
Conversation
Member
🎉 This LGTM, (assuming all checks are green) |
Member
Author
|
Even with @sroet's review, I will leave this open for at least 24 hours, merging no earlier than Tue 22 Dec 16:00 GMT (17:00 local). 😉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally settling internally on the API: You can now set up an OPS storage with:
No more of this
from_backendstuff!