Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(structured outputs): avoid parsing empty empty content - #2023

#2023
Merged
RobertCraigie merged 1 commit into
openai:nextopenai/openai-python:nextfrom
StarSpark-AI:patch-1StarSpark-AI/openai-python:patch-1Copy head branch name to clipboard
Jan 16, 2025
Merged

fix(structured outputs): avoid parsing empty empty content#2023
RobertCraigie merged 1 commit into
openai:nextopenai/openai-python:nextfrom
StarSpark-AI:patch-1StarSpark-AI/openai-python:patch-1Copy head branch name to clipboard

Conversation

@rjoshi

@rjoshi rjoshi commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

Fixing #1763 where parsing often fails when content is empty string instead of None.

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Additional context & links

Fixing openai#1763 where parsing often fails when content is empty string instead of None.
@rjoshi
rjoshi requested a review from a team as a code owner January 15, 2025 23:30
@RobertCraigie RobertCraigie changed the title Refactor condition to leverage truthiness for message.content in parsing fix(structured outputs): avoid parsing empty empty content Jan 16, 2025
@RobertCraigie
RobertCraigie changed the base branch from main to next January 16, 2025 12:43

@RobertCraigie RobertCraigie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RobertCraigie
RobertCraigie merged commit 6d3513c into openai:next Jan 16, 2025
@stainless-app stainless-app Bot mentioned this pull request Jan 16, 2025
stainless-app Bot pushed a commit that referenced this pull request Jan 17, 2025
Fixing #1763 where parsing often fails when content is empty string instead of None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.