Support getting number of children of non-existent vertex in Levelled Forest#8207
Merged
jordanschalm merged 1 commit intoNov 28, 2025
masteronflow/flow-go:masterfrom
jord/levelled-forest-num-children-bugonflow/flow-go:jord/levelled-forest-num-children-bugCopy head branch name to clipboard
Merged
Support getting number of children of non-existent vertex in Levelled Forest#8207jordanschalm merged 1 commit intomasteronflow/flow-go:masterfrom jord/levelled-forest-num-children-bugonflow/flow-go:jord/levelled-forest-num-children-bugCopy head branch name to clipboard
jordanschalm merged 1 commit into
masteronflow/flow-go:masterfrom
jord/levelled-forest-num-children-bugonflow/flow-go:jord/levelled-forest-num-children-bugCopy head branch name to clipboard
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
jordanschalm
commented
Nov 28, 2025
| // GetNumberOfChildren returns number of children of given vertex | ||
| // GetNumberOfChildren returns the number of children of the given vertex that exist in the forest. | ||
| func (f *LevelledForest) GetNumberOfChildren(id flow.Identifier) int { | ||
| container := f.vertices[id] // if vertex does not exist, container is the default zero value for vertexContainer, which contains a nil-slice for its children |
Contributor
Author
There was a problem hiding this comment.
This comment was wrong, because vertex containers were stored as pointers. Accessing fields on the returned nil pointer caused an exception.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
durkmurder
approved these changes
Nov 28, 2025
peterargue
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.