Fix SetColumnOffset() subtracting a bool value instead of scrollbar width - #142
#142Merged
Merged
Fix SetColumnOffset() subtracting a bool value instead of scrollbar width#142
Conversation
ocornut
added a commit
that referenced
this pull request
Feb 23, 2015
Fix SetColumnOffset() subtracting a bool value instead of scrollbar width
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw the new commits and version you pushed out. I noticed a regression when I updated my programs with it, where clicking on column borders to resize would cause them to quickly move to the left, even if I didn't move the mouse.
Looked at the code real quick and noticed something a little fishy when x values were subtracted with something referencing y, and then noticed it was also a bool. Switched it back to g.Style.ScrollBarWidth and things seemed to get back to normal!