Patch/pcfill (#119)

* changes to chavas pc_fill to ensure validility of Vmax (min of 20 m/s) and using regression with Vmax (instead of Vmax**2) when R34 is unknown

* adding lower bound for Vsrm and filling in any R34 nans for the Courtney and Knaff Pc fill method

* adding the pcfill test to compare to Takis's results.

* rounding pc pressure fill output

* adding in finalized test_pcfill reference and input files

* changing test assertion due to rounding used in function

* updating reference files for test_vortex_track using improved background pressure filling fix

Adding feature for filling pressure using a regression method (#117)

* moving carq_ref to above holland B calculation and just using that to compute it instead of needing to take the nanmean

* add Pc filling method and setting to the existing persistentB option as default

* changing PcFillMethod option names to keep the existing convection

* adding general formula and constants for the chavas 2025 Pc regression method

* corrections to code to pass existing tests, adding test for the new Pc filling regression method by Chavas et al 2025

* finalizing the Chavas method using one regression function where R34 is available and another one when it is not

* length should be 11 like rmw with smoothing

* adding PcFillMethod option to stormevent.py

* correcting doi url for the Chavas paper

* Fix USGS test

* adding the Courtney Knaff 2009 regression method for filling Pc, changing the assunption on translation speed units to kts, this needs revisiting to be sure

* Fix storm moving speed unit conversion for Pc fill

* Fix style

* Revert previous change and make sure storm moving speed is always stored in knots

---------

Co-authored-by: SorooshMani-NOAA <soroosh.mani@noaa.gov>

Feature/rmax fill nosmooth (#114)

* changing format of hours and minutes in moving mean smoother call

* moving the moving mean smoother for the RMW fill to a function for clarity

* adding option for the penny et al (2023) rmw regression fill without the moving mean smoother

* adding regression fill option with_smoothing that is same as the default option that does not specify smoothing for some added clarity

* changing to make the penny_2023 flag actually just equal to the one ending with_smoothing flag

* remove macos from test matrix

---------

Co-authored-by: Soroosh.Mani <Soroosh.Mani@noaa.gov>

Add option for choosing rmw fill method (#112)

* Add option for choosing rmw fill method, default to psurge2.9 - no tests added yet

* Style fix

* Add some test for rmw fill

* Styling fix

* Update name of the RMW fill method

* Add test for setting invalid rmw fill

Bugfix/misc (#111)

* Fix usgs stormlist duplication

* Fix test ref due to updated response

* Reduce warnings

* Styling

update test refs

Bug fix/storm speed (#104)

* correction for speed and bearing calculation, previously applied computation uniformly for all unique datetimes even though they can be across different forecasts

* updated the modified reference files. best-track is unchanged except for the first time which was previously set to be 0, now the next time is propagated backward

* handling special case where no previous times available for new forecast

* make sure ^Cw is not larger than the maximum radii of the strongest isotach

* reformat

* Fix tests

* check for negative time intervals and use abs for computing speed and forward_azimuth for computing bearing (usually inverse_azimuth)

---------

Co-authored-by: SorooshMani-NOAA <soroosh.mani@noaa.gov>

Feature/rmax biascorrection (#100)

* adding bias correction matrix for RMW forecast computation

* adding bias correction of vmax, lat, and radii for RMW regression forecast

* keeping bias corrected value of radii from previous timestep if preserving it

* changing reference files to pass tests

using the Psurge v2.9 regression method for filling in Rmax in OFCL a…

…dvisories (#96)

* adding complete method for rmax forecast regression without smoothing or limiting

* reformatting back to black

* adding the upper and lower bounds for RMW forecast

* changing upper bound to be larger of 120.0 nmi or rmw0

* changing sorting of advisories by index to avoid out of order isotach_radius

* adding 3-pt rolling mean for the rmax forecasts

* finalizing the smoothing which interpolates to 12-hr intervals where required and then computes a 24-hr moving mean

* preserving 34-kt isotach for lead times > 72-hrs if Vmax still above 34-kt

* adding changes to the forecasts where the isotachs are correctly ordered and filling in RMW using regression technique from NHC

* adding changes to the OFCL deck for RMW regression

* ensuring presence of rads

* initialize rads

* Update test configuration

* Remove python 3.12 from test matrix

* Quick-test on lowser supported python

* Try test without multiworker

* Fixing python version for quicktest

* Use py3.10 instead of min for coverage test

* adding RMW regression coefficients into const.py and making a test for the retrieval function

* switching to keep 50-kt radius as well as 34-kt

* modified OFCL RMW forecast tests preserving the 50-kt isotach as well as 34-kt

---------

Co-authored-by: SorooshMani-NOAA <soroosh.mani@noaa.gov>

Storm name match 2 (#95)

* Fix name matching logic

* Style fix

Ignoring automated test (ran locally) due to tests getting stuck!