using the Psurge v2.9 regression method for filling in Rmax in OFCL advisories#96
using the Psurge v2.9 regression method for filling in Rmax in OFCL advisories#96SorooshMani-NOAA merged 21 commits intomainoceanmodeling/StormEvents:mainfrom feature/rmax_Psurgev29oceanmodeling/StormEvents:feature/rmax_Psurgev29Copy head branch name to clipboard
Conversation
|
Likely fixed #97 by just sorting the individual advisories by |
…required and then computes a 24-hr moving mean
…red and filling in RMW using regression technique from NHC
|
|
||
| # Regression coefficients for the Rmax forecast | ||
| # ref: Penny et al. (2023). https://doi.org/10.1175/WAF-D-22-0209.1 | ||
| def get_regression_coefs(fcst_hr, radii_values): |
There was a problem hiding this comment.
@WPringle it'd be nice if you could add a simple test for this function, by just providing fcst hour and radii, what do you expect to see. Just a couple of basic cases.
There was a problem hiding this comment.
added in latest commit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 91.33% 91.70% +0.36%
==========================================
Files 18 19 +1
Lines 1927 1988 +61
==========================================
+ Hits 1760 1823 +63
+ Misses 167 165 -2 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@WPringle please let me know when this is ready to merge. All looks good from my perspective (after including comments I made before) |
|
@SorooshMani-NOAA ready to merge but an unrelated test is now failing: |
|
@WPringle thanks, I'll look into it |
|
@WPringle after rerunning the test (to resolve the temporary server issue) it seems that the tests are not updated after the 50kt radius fix. Can you run the tests locally and see if it's doing the right thing for 50kt and 34kt and if so update the test refs? When I run locally I see that some 34kt and 50kt columns are different between the test output and ref. |
|
@SorooshMani-NOAA Thanks, yes some of the RMW forecasts did change and I think correctly. updated the reference files. |
https://github.com/saeed-moghimi-noaa/Next-generation-psurge-tasks/issues/28