docs: validate's duplicate-enum lint; allOf's dropped keywords#1108
Merged
reuvenharrison merged 2 commits intoJul 22, 2026
mainoasdiff/oasdiff:mainfrom
docs/validate-allof-accuracyoasdiff/oasdiff:docs/validate-allof-accuracyCopy head branch name to clipboard
Merged
docs: validate's duplicate-enum lint; allOf's dropped keywords#1108reuvenharrison merged 2 commits intomainoasdiff/oasdiff:mainfrom docs/validate-allof-accuracyoasdiff/oasdiff:docs/validate-allof-accuracyCopy head branch name to clipboard
reuvenharrison merged 2 commits into
mainoasdiff/oasdiff:mainfrom
docs/validate-allof-accuracyoasdiff/oasdiff:docs/validate-allof-accuracyCopy head branch name to clipboard
Conversation
VALIDATE.md predates the duplicate-enum-value lint (#1023); it joins the warning examples. ALLOF.md said some fields are "not merged" but if/then/else, dependentSchemas, and unevaluatedProperties are dropped outright, with semantic consequences; state it and link #1097. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1108 +/- ##
=======================================
Coverage ? 89.00%
=======================================
Files ? 295
Lines ? 14676
Branches ? 0
=======================================
Hits ? 13062
Misses ? 1120
Partials ? 494
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two accuracy fixes found while sweeping the docs after #1107:
duplicate-enum-value(validate: warn on duplicate enum values (#980) #1023) andambiguous-parameter-serialization(validate: flag a parameter whose type union mixes structured and scalar #1103). Both join the warning-severity examples, and the intro no longer claims every finding is a spec-defined violation.if/then/else,dependentSchemas, andunevaluatedPropertiesare dropped outright, even for schemas with noallOf— with semantic consequences (a closed schema opens; changes inside conditionals vanish from a--flatten-allofcomparison). Stated plainly and linked to flatten: Merge silently drops if/then/else, dependentSchemas, and unevaluatedProperties #1097.🤖 Generated with Claude Code