refactor(checker): rename SCREAMING_SNAKE_CASE stability constants to MixedCaps#1032
Merged
reuvenharrison merged 1 commit intoJun 21, 2026
mainoasdiff/oasdiff:mainfrom
rename-stability-constantsoasdiff/oasdiff:rename-stability-constantsCopy head branch name to clipboard
Merged
refactor(checker): rename SCREAMING_SNAKE_CASE stability constants to MixedCaps#1032reuvenharrison merged 1 commit intomainoasdiff/oasdiff:mainfrom rename-stability-constantsoasdiff/oasdiff:rename-stability-constantsCopy head branch name to clipboard
reuvenharrison merged 1 commit into
mainoasdiff/oasdiff:mainfrom
rename-stability-constantsoasdiff/oasdiff:rename-stability-constantsCopy head branch name to clipboard
Conversation
… MixedCaps
STABILITY_DRAFT / ALPHA / BETA / STABLE use a C/Python casing convention,
not Go. Rename them to StabilityDraft / StabilityAlpha / StabilityBeta /
StabilityStable and migrate all internal usages. The values ("draft",
"alpha", "beta", "stable") are unchanged, so no CLI or serialized behavior
changes.
The old names are kept as deprecated aliases, since they are exported and
a library consumer may reference them; they can be dropped in a future
major release.
Closes #1031.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
=======================================
Coverage 87.51% 87.51%
=======================================
Files 277 277
Lines 14431 14431
=======================================
Hits 12629 12629
Misses 1289 1289
Partials 513 513
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1031.
STABILITY_DRAFT/STABILITY_ALPHA/STABILITY_BETA/STABILITY_STABLEuse a C/Python casing convention, not Go (which uses MixedCaps). staticcheck flags this as ST1003.Change
StabilityDraft/StabilityAlpha/StabilityBeta/StabilityStableand migrated all internal usages."draft","alpha","beta","stable") are unchanged, so there is no CLI or serialized behavior change.// Deprecated:aliases, since they are exported and a library consumer may reference them. They can be dropped in a future major release.Scope
A repo-wide scan confirmed these four were the only SCREAMING_SNAKE_CASE Go identifiers. Environment-variable name strings (
OASDIFF_CONFIG,GITHUB_OUTPUT, etc.) andos.O_*flags are correctly cased and out of scope.Build,
go vet,gofmt, and the full test suite pass.