Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(vite): don't strip buildAssetsDir from vite-node SSR ids#35040

Merged
danielroe merged 1 commit into
mainnuxt/nuxt:mainfrom
fix/buildassetsdir-collisionnuxt/nuxt:fix/buildassetsdir-collisionCopy head branch name to clipboard
May 12, 2026
Merged

fix(vite): don't strip buildAssetsDir from vite-node SSR ids#35040
danielroe merged 1 commit into
mainnuxt/nuxt:mainfrom
fix/buildassetsdir-collisionnuxt/nuxt:fix/buildassetsdir-collisionCopy head branch name to clipboard

Conversation

@danielroe

@danielroe danielroe commented May 11, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #24035

📚 Description

vite-node strips base from any module id it receives... but vite's SSR transform never prepends base to URLs, so the strip is unnecessary for SSR ids....

@bolt-new-by-stackblitz

bolt-new-by-stackblitz Bot commented May 11, 2026

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions Bot added 5.x 🐛 bug Something isn't working as expected labels May 11, 2026
@coderabbitai

This comment has been minimized.

Sign in to view
@danielroe
danielroe requested a review from antfu May 11, 2026 11:45
@codspeed-hq

codspeed-hq Bot commented May 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 20 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing fix/buildassetsdir-collision (407737e) with main (c32b704)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@pkg-pr-new

pkg-pr-new Bot commented May 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@35040

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@35040

nuxt

npm i https://pkg.pr.new/nuxt@35040

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@35040

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@35040

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@35040

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@35040

commit: 407737e

antfu
antfu approved these changes May 12, 2026
View reviewed changes

@antfu antfu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@danielroe
danielroe merged commit ff68a50 into main May 12, 2026
32 checks passed
@danielroe
danielroe deleted the fix/buildassetsdir-collision branch May 12, 2026 06:32
@github-actions github-actions Bot mentioned this pull request May 12, 2026
Draft
5 tasks
danielroe added a commit that referenced this pull request May 13, 2026
@danielroe
fix(vite): don't strip buildAssetsDir from vite-node SSR ids (#35040)
b1dea17
@github-actions github-actions Bot mentioned this pull request May 13, 2026
Merged
danielroe added a commit that referenced this pull request May 13, 2026
@danielroe
fix(vite): don't strip buildAssetsDir from vite-node SSR ids (#35040)
df19c3f
@github-actions github-actions Bot mentioned this pull request May 13, 2026
Merged
davidstackio pushed a commit to davidstackio/nuxt that referenced this pull request May 30, 2026
@danielroe @davidstackio
fix(vite): don't strip buildAssetsDir from vite-node SSR ids (nuxt#35040
a35d8be 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antfu antfu antfu approved these changes

Assignees

No one assigned

Labels

5.x 🐛 bug Something isn't working as expected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dev server error 500 ERR_LOAD_URL if app.buildAssetsDir same as source directory name

2 participants

@danielroe @antfu
Morty Proxy This is a proxified and sanitized view of the page, visit original site.