Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

BUG: Fix Linux QEMU CI workflow #27616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

charris
Copy link
Member

@charris charris commented Oct 22, 2024

Backport of #27613.

Fix #27601

Fix Linux QEMU CI workflow for cross-architecture builds

Issue:

  • The Linux QEMU CI workflow was failing across multiple architectures (arm, ppc64le, s390x, riscv64) due to improper container setup and execution for cross-architecture builds as shown in figure.

image

Solution:

  1. Added --platform flag to docker run commands to explicitly specify the target architecture.
  2. Introduced a new ARCH variable in the matrix to simplify architecture specification.
  3. Updated the docker run commands in the "Creates new container", "Meson Build", and "Run Tests" steps to use the --platform flag.

Maintained:

  1. Retained the use of qemu-user-static for QEMU emulation setup, which is necessary for cross-architecture builds.
  2. Kept the existing cache mechanism for docker containers to improve workflow efficiency.

Outcome:

  • These changes ensure that the correct architecture is used throughout the workflow, allowing for successful cross compilation and testing across all target architectures.

include the --platform flag in all docker run commands
@charris charris added 00 - Bug 08 - Backport Used to tag backport PRs labels Oct 22, 2024
@charris charris added this to the 2.1.3 release milestone Oct 22, 2024
@charris charris merged commit 5e179c7 into numpy:maintenance/2.1.x Oct 22, 2024
65 checks passed
@charris charris deleted the backport-27613 branch October 22, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
00 - Bug 08 - Backport Used to tag backport PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.