Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

BUG: Fix Linux QEMU CI workflow #27613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

abhishek-iitmadras
Copy link
Contributor

@abhishek-iitmadras abhishek-iitmadras commented Oct 21, 2024

Fix #27601

Fix Linux QEMU CI workflow for cross-architecture builds

Issue:

  • The Linux QEMU CI workflow was failing across multiple architectures (arm, ppc64le, s390x, riscv64) due to improper container setup and execution for cross-architecture builds as shown in figure.

image

Solution:

  1. Added --platform flag to docker run commands to explicitly specify the target architecture.
  2. Introduced a new ARCH variable in the matrix to simplify architecture specification.
  3. Updated the docker run commands in the "Creates new container", "Meson Build", and "Run Tests" steps to use the --platform flag.

Maintained:

  1. Retained the use of qemu-user-static for QEMU emulation setup, which is necessary for cross-architecture builds.
  2. Kept the existing cache mechanism for docker containers to improve workflow efficiency.

Outcome:

  • These changes ensure that the correct architecture is used throughout the workflow, allowing for successful cross compilation and testing across all target architectures.

cc @charris @andyfaff @seiko2plus @rgommers @r-devulap @Mousius

include the --platform flag in all docker run commands
@abhishek-iitmadras abhishek-iitmadras changed the title Update linux_qemu.yml BUG: Fix Linux QEMU CI workflow Oct 21, 2024
@charris charris added 00 - Bug 09 - Backport-Candidate PRs tagged should be backported labels Oct 21, 2024
@seiko2plus seiko2plus merged commit d315181 into numpy:main Oct 22, 2024
68 checks passed
@seiko2plus
Copy link
Member

Thanks a lot, @abhishek-iitmadras, for the quick fix!

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Oct 22, 2024
@abhishek-iitmadras abhishek-iitmadras deleted the qemu branch October 24, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux QEMU CI currently failing
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.