Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

BLD: Update RELEASE_WALKTHROUGH and cythonize. #14404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2019
Merged

BLD: Update RELEASE_WALKTHROUGH and cythonize. #14404

merged 1 commit into from
Sep 1, 2019

Conversation

charris
Copy link
Member

@charris charris commented Aug 31, 2019

Make it less likely that the wrong cython version is used for
building or cythonizing NumPy. This is motivated by the upcoming
Python 3.8 release that requires the cython 0.29.13 as of 3.8.0b4.

@charris
Copy link
Member Author

charris commented Aug 31, 2019 •
edited
Loading

I think we should remove the fallback use of the cython command in cythonize and only allow the use of the module installed in the python version used. That lessens the chance of an incorrect cython version being used.

@charris charris mentioned this pull request Aug 31, 2019
Closed
eric-wieser
eric-wieser reviewed Aug 31, 2019
View reviewed changes
tools/cythonize.py Show resolved Hide resolved
eric-wieser
eric-wieser reviewed Aug 31, 2019
View reviewed changes
tools/cythonize.py Outdated Show resolved Hide resolved
rgommers
rgommers reviewed Aug 31, 2019
View reviewed changes
tools/cythonize.py Outdated Show resolved Hide resolved
@rgommers
Copy link
Member

I think we should remove the fallback use of the cython command in cythonize and only allow the use of the module installed in the python version used. That lessens the chance of an incorrect cython version being used.

That's worth considering indeed. It means we stop treating Cython as a compiler, and make it a build-time dependency like setuptools.

@charris charris force-pushed the update-release-walkthrough branch 4 times, most recently from a6e9c75 to 65d8249 Compare August 31, 2019 23:50
@charris
Copy link
Member Author

charris commented Sep 1, 2019

That's worth considering indeed. It means we stop treating Cython as a compiler, and make it a build-time dependency like setuptools.

I'll wait till this goes in, then submit a PR that removes that.

@mattip
Copy link
Member

mattip commented Sep 1, 2019

LGTM. xref gh-14378 which pins all build/test dependencies and will hopefully notify when upstream releases a new version

@charris charris mentioned this pull request Sep 1, 2019
Merged
@charris
BLD: Update RELEASE_WALKTHROUGH and cythonize.
a484293 
Make it less likely that the wrong cython version is used for
building or cythonizing NumPy. This is motivated by the upcoming
Python 3.8 release that requires the cython 0.29.13 as of 3.8.0b4.
@charris charris force-pushed the update-release-walkthrough branch from 65d8249 to a484293 Compare September 1, 2019 14:57
@charris charris merged commit 3db7ff6 into numpy:master Sep 1, 2019
@charris charris deleted the update-release-walkthrough branch September 1, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers left review comments

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
32 - Installation Problems installing or compiling NumPy component: build component: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charris @rgommers @mattip @eric-wieser
Morty Proxy This is a proxified and sanitized view of the page, visit original site.