-
-
Notifications
You must be signed in to change notification settings - Fork 11k
BUILD: move all test dependencies to ./test_requirements.txt #14378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7945660
to
280689d
Compare
280689d
to
bfe255f
Compare
543e72d
to
d736b69
Compare
d736b69
to
e5f4c29
Compare
The Check_Dependencies test is correctly failing:
Now we need to decide what to do.
|
Is it possible to mark that task as failable, so that we get an X from azure on just one CI integration, but that x does not aggregate to an overall GitHub ci failure? |
I'd much prefer to use a service for this.
that's not correct, GitHub definitely has fine-grained permissions, and a well-written service should need nothing more than perhaps a "read email addresses" to be installed. |
Please put |
Note that nose imports the |
I don't see how, the Job spec does not have any "failable" option I can see |
I am exploring options for sending an email when the test fails. I think we can add an extension for SendMail, do we have an organizational email entity that can sign up with them to get a token? |
Isn't issuing PRs to update dependencies what Dependabot is for? |
It seems dependabot may work out. In order to get the ball rolling, can we merge this PR as is, so that we can set up dependabot (or another service) and point them to the new file? |
Merging so we can get started. This will break #14404, so I will update that. Thanks Matti. |
Move all the test dependencies to a single
test_requirements.txt
. Perhaps we should have abuild_requirements.txt
with only cython?The real goal is to enable testing whether these packages have updates, so I added use of
pip list -o
to list outdated packages.Probably
pip install -r test_requirements.txt
should get a shoutout somewhere in the development documentation