Add overlap measure#8
Open
amadanmath wants to merge 2 commits into
Open
Add overlap measure#8amadanmath wants to merge 2 commits into
amadanmath wants to merge 2 commits into
Conversation
|
HI, i'm looking into forking this and making a new module and repo, are you ok with me just adding the measure there? |
|
This is available in simstring which is a fork of this which is being maintained (for now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One obstacle to implementing Overlap measure is the fact that the original implementation gives max size for that measure as
INT_MAX.To solve this, one can only restrict this at search time.
There may also be a possibility to implement the max size for mongo, however I've never worked with it and I don't dare touch it without even having it installed. :)