Pull request overview

This PR moves conversion/session state (text encoding, time zone, and other ParameterStatus-driven values) from PgSerializerOptions to a per-connector PgConversionContext, and threads that context through binding/reading/writing so Npgsql can react to mid-session state changes (notably client_encoding and TimeZone).

Changes:

• Introduces per-connection NpgsqlConnector.ConversionContext, rotates it on relevant ParameterStatus updates, and updates reader/writer/binding call sites to use it.
• Adjusts type binding (PgConcreteTypeInfo) to distinguish invariant vs context-dependent descriptors and re-resolve buffer requirements at runtime when needed.
• Updates NodaTime legacy timestamp-tz converters to resolve time zone at read-time from the connection context instead of capturing it at type-mapping creation time.

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.

        if (result is { IsDefault: false, TypeInfo.Type: var typeToConvert } && typeToConvert == type)
            return;

        var objectInfo = DataFormat is DataFormat.Text && type is not null ? GetObjectConversionContext(conversionContext) : _objectConversionContext;
        if (objectInfo.TypeInfo is not null && (typeof(object) == type || objectInfo.TypeInfo.Type == type))
        {
            result = objectInfo;
            return;

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

        var objectInfo = DataFormat is DataFormat.Text && type is not null ? GetObjectConversionContext(conversionContext) : _objectConversionContext;
        if (objectInfo.TypeInfo is not null && (typeof(object) == type || objectInfo.TypeInfo.Type == type))
        {
            result = objectInfo;
            return;

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.

    /// Bind the current value to the type info, truncate (if applicable), take its size, and do any final validation before writing.
    internal void Bind(PgConversionContext conversionContext, out DataFormat format, out Size size, DataFormat? requiredFormat = null)
    {
        if (TypeInfo is null || ConcreteTypeInfo is null)
            ThrowHelper.ThrowInvalidOperationException($"Missing type info, {nameof(ResolveTypeInfo)} needs to be called before {nameof(Bind)}.");

        // Invalidate a cached binding whose format no longer matches what the caller requires —
        // the type info may still support the required format, just not the format the cached
        // binding chose. Re-running Bind with the new preference can produce a satisfying binding.
        if (_isBound && requiredFormat is not null && _binding.DataFormat != requiredFormat.GetValueOrDefault())
        {
            DisposeBindingState();

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated no new comments.