Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add COPY operations dispose on initialization failure - #6220

#6220
Merged
vonzshik merged 6 commits into
mainnpgsql/npgsql:mainfrom
6219-fix-copy-operation-dispose-on-init-failnpgsql/npgsql:6219-fix-copy-operation-dispose-on-init-failCopy head branch name to clipboard
Oct 2, 2025
Merged

Add COPY operations dispose on initialization failure#6220
vonzshik merged 6 commits into
mainnpgsql/npgsql:mainfrom
6219-fix-copy-operation-dispose-on-init-failnpgsql/npgsql:6219-fix-copy-operation-dispose-on-init-failCopy head branch name to clipboard

Conversation

@vonzshik

Copy link
Copy Markdown
Contributor

Fixes #6219

@vonzshik
vonzshik requested a review from roji as a code owner September 23, 2025 08:18

@roji roji left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though see suggestions about slightly cleaner/more explicit state management.

Comment thread src/Npgsql/NpgsqlBinaryExporter.cs Outdated
Comment thread src/Npgsql/NpgsqlBinaryImporter.cs Outdated
Comment thread src/Npgsql/NpgsqlRawCopyStream.cs Outdated
@vonzshik
vonzshik requested a review from roji October 1, 2025 15:29
Comment thread src/Npgsql/NpgsqlBinaryExporter.cs Outdated
@vonzshik
vonzshik enabled auto-merge (squash) October 2, 2025 11:07
@vonzshik
vonzshik merged commit d58efec into main Oct 2, 2025
16 checks passed
@vonzshik
vonzshik deleted the 6219-fix-copy-operation-dispose-on-init-fail branch October 2, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correctly dispose COPY operations objects if they fail during initialization

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.