Modernize array tests and other test cleanup - #5279
#5279Modernize array tests and other test cleanup#5279
Conversation
| } | ||
|
|
||
| [Test, Description("Roundtrips an empty multi-dimensional array.")] | ||
| public async Task Empty_multidimensional_array() |
There was a problem hiding this comment.
Can we add this and the zero dimension case to the test cases?
There was a problem hiding this comment.
This one has been replaced by Write_empty_multidimensional_array, since PG normalizes empty multidimensional arrays to single-dimensional (so we can't use the generic test above with the test cases).
As for the zero dimension case, isn't it the one that's already there (test case Empty_array)?
There was a problem hiding this comment.
This one has been replaced by Write_empty_multidimensional_array, since PG normalizes empty multidimensional arrays to single-dimensional (so we can't use the generic test above with the test cases).
👍
As for the zero dimension case, isn't it the one that's already there (test case Empty_array)?
Yeah Zero_dimensional seems to be a duplicate test.
There was a problem hiding this comment.
There's no more Zero_dimensional test any more after this PR (I deleted it because the Empty_array case is the same). Is there still a duplicate test after this PR that I'm missing?
There was a problem hiding this comment.
Is there still a duplicate test after this PR that I'm missing?
Not at all!
This is test cleanup work originally done in #5125 which was superceded.