Make Npgsql use SSLStream for ssl connections instead of using Mono.Secu... #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecurity. Mono.Security assembly is used by Npgsql to provide ssl support. SSLStream class found in .Net class library also provides support for ssl. Before this patch, Npgsql used Mono.Security by default. With this change, it will use SSLStream class found in .Net class library.
franciscojunior
added a commit
that referenced
this pull request
Jul 21, 2014
Make Npgsql use SSLStream for ssl connections instead of using Mono.Security
Member
|
@franciscojunior, just a thought - how about setting up some tests around authentication, SSL, etc.? I know that not everything will be possible to test on the build server, but maybe it's worth trying? Because all this would probably involve extra setup effort on the Postgresql test backend, we could make these tests not run by default (with [Explicit]), and run them on the build server. What do you think? If you agree we can open a new issue for this... |
Member
Author
|
I think this is an excellent idea! +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rity.
Mono.Security assembly is used by Npgsql to provide ssl support.
SSLStream class found in .Net class library also provides support for ssl.
Before this patch, Npgsql used Mono.Security by default.
With this change, it will use SSLStream class found in .Net class library.