Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@franciscojunior
Copy link
Member

Fix #264
Add license files.

@roji
Copy link
Member

roji commented Jul 11, 2014

@franciscojunior, I don't remember anymore from which mono version I took the .NET 4.0 Mono.Security...

Maybe we should try to finally get rid of this dependency (as in #127), what do you think? We don't seem to really need it?

@franciscojunior
Copy link
Member Author

Maybe we should try to finally get rid of this dependency (as in #127), what do you think? We don't seem to really need it?

I was thinking about being more conservative and change the default to use SSLStream as default in the 2.2 version and if there is no complaint we could remove it in the 2.3 version.

With the feedback from @hultqvist I'm more confident about changing the default to use SSLStream.

Here is where we specify to not use SSLStream by default:
https://github.com/npgsql/Npgsql/blob/master/Npgsql/Npgsql/NpgsqlConnector.cs#L258

What do you think?

@roji
Copy link
Member

roji commented Jul 11, 2014

That sounds like a good plan! This way we have all of 2.3 to see how users
are doing...

Am Freitag, 11. Juli 2014 schrieb Francisco Figueiredo Jr. :

Maybe we should try to finally get rid of this dependency (as in #127
#127), what do you think? We
don't seem to really need it?

I was thinking about being more conservative and change the default to use
SSLStream as default in the 2.2 version and if there is no complaint we
could remove it in the 2.3 version.

With the feedback from @hultqvist https://github.com/hultqvist I'm more
confident about changing the default to use SSLStream.

Here is where we specify to not use SSLStream by default:

https://github.com/npgsql/Npgsql/blob/master/Npgsql/Npgsql/NpgsqlConnector.cs#L258

What do you think?


Reply to this email directly or view it on GitHub
#273 (comment).

@franciscojunior
Copy link
Member Author

That sounds like a good plan! This way we have all of 2.3 to see how users
are doing...

Great! I'll create the pull request for that.

@franciscojunior
Copy link
Member Author

Just for completeness, the pull request I created was the #275 to change the default to use SSLStream

franciscojunior added a commit that referenced this pull request Jul 30, 2014
Update Mono.Security.dll assembly to Mono version 3.4.0
@franciscojunior franciscojunior merged commit 1dfa54d into npgsql:master Jul 30, 2014
franciscojunior added a commit that referenced this pull request Jul 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.