Fix: element type error when check reply#219
Merged
yanyongyu merged 2 commits intoJul 21, 2026
nonebot:masternonebot/adapter-qq:masterfrom
botbikamordehai2-sketch:fix/issue-217-1784548501botbikamordehai2-sketch/adapter-qq:fix/issue-217-1784548501Copy head branch name to clipboard
Merged
Fix: element type error when check reply#219yanyongyu merged 2 commits intononebot:masternonebot/adapter-qq:masterfrom botbikamordehai2-sketch:fix/issue-217-1784548501botbikamordehai2-sketch/adapter-qq:fix/issue-217-1784548501Copy head branch name to clipboard
yanyongyu merged 2 commits into
nonebot:masternonebot/adapter-qq:masterfrom
botbikamordehai2-sketch:fix/issue-217-1784548501botbikamordehai2-sketch/adapter-qq:fix/issue-217-1784548501Copy head branch name to clipboard
Conversation
yanyongyu
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a user quotes/forwards a message in a group with 群全量 event mode,
_check_replyassumes the first element inmsg_elementsis a reply segment and tries to access itsauthorattribute. But forwarded messages produce a different segment type (e.g., 'multi_msg' or 'forward'), which may not haveauthor, causing a parsing error.Fix
Add a check that the first element is actually a 'reply' type before attempting to use it as
event.reply. If it's not a reply, return early without setting reply. This prevents crashes and correctly ignores non-reply elements.Closes #217