Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Discussion options

There's very little documentation around it and how they are implemented; in the codebase things are implemented in a few different ways (wrap/unwraphandler, decorator handlers, straight up functions, ...) and it's quite a bit of a barrier given that we will not be sure what/how things will be supported (e.g. #4097).

The overall API also is not really friendly, by having to manually wrap and manually call each wrapped method of the handler in the interceptor dispatch method.

Any guidance and documentation around it would be helpful :)

You must be logged in to vote

Replies: 1 comment · 3 replies

Comment options

Yeah, there is currently also no gold standard example

You must be logged in to vote
3 replies
@metcoder95
Comment options

I wonder it bringing back the old AbstractHandler could help here.

As @Uzlopak says, there's no best-practice guide or example to use as a baseline.
Nonetheless, if open to contribute, we start building one while guiding you as well so we can keep it for further reference

@Uzlopak
Comment options

@metcoder95

What is the simplest interceptor to refactor to gold standard? Maybe we can tackle it, together?

@metcoder95
Comment options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
🙏
Q&A
Labels
None yet
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.