fix: don't require stream package in codebase#520
Merged
mcollina merged 4 commits intonodejs:mainnodejs/readable-stream:mainfrom Jun 29, 2023
jeswr:fix/readable-stream-no-stream-importjeswr/readable-stream:fix/readable-stream-no-stream-importCopy head branch name to clipboard
Merged
fix: don't require stream package in codebase#520mcollina merged 4 commits intonodejs:mainnodejs/readable-stream:mainfrom jeswr:fix/readable-stream-no-stream-importjeswr/readable-stream:fix/readable-stream-no-stream-importCopy head branch name to clipboard
stream package in codebase#520mcollina merged 4 commits intonodejs:mainnodejs/readable-stream:mainfrom
jeswr:fix/readable-stream-no-stream-importjeswr/readable-stream:fix/readable-stream-no-stream-importCopy head branch name to clipboard
Conversation
mcollina
reviewed
May 16, 2023
| @@ -0,0 +1,77 @@ | ||
| import { exec } from 'child_process' |
Contributor
Author
There was a problem hiding this comment.
See line 27 (note this is a copy /paste of a subset of the code in the nodejs fixtures)
Contributor
Author
|
Bump @vweevers @benjamingr |
Contributor
|
I don't have time to review. |
Contributor
Author
|
@mcollina it doesn't look like the others have time to review so can this be released? |
4 tasks
|
Would it be possible to merge this package? Many of our downstream users are running into issues because of this Happy to help where possible! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #516.
Supercedes #517 and #519.
This replaces
require('stream')withrequire('../../lib/stream.js')in the build script so that thestreammodule is never imported.Since #517 I've moved the regression test to a new folder in the root since the other test fixtures are being copied from the nodejs codebase; wheras the one I add is specific to
readable-stream.