chore: don't polyfill stream in webpack.browser.config.mjs#517
Closed
jeswr wants to merge 5 commits intonodejs:mainnodejs/readable-stream:mainfrom
Closed
chore: don't polyfill stream in webpack.browser.config.mjs#517jeswr wants to merge 5 commits intonodejs:mainnodejs/readable-stream:mainfrom
jeswr wants to merge 5 commits intonodejs:mainnodejs/readable-stream:mainfrom
Conversation
Contributor
Author
|
Was expecting Webpacking to fail with this change. Will investigate by Monday at the latest. |
Contributor
Author
Member
|
I thought it was a simple fix, but it's actually harder than the time I currently have available to fix it. @jeswr would you mind to identify a fix? @ShogunPanda could you take a look as well? |
Contributor
Author
|
Unfortunately I'm quite time poor myself at present @mcollina, so it is unlikely I will have a chance in the next 2 weeks to look into it. If the issue hasn't been fixed after that - or if I find time beforehand - then I'll take a look. |
This was referenced May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
4.3.0to4.4.0, usingesbuild --bundleto build will report an errorCould not resolve "stream"#516 by adding a new webpack config to import what is effectively the fileimport * as all from 'readable-stream'