cluster: remove unused backlog argument#8877
Closed
mscdex wants to merge 1 commit into
nodejs:masternodejs/node:masterfrom
mscdex:cluster-remove-unused-argmscdex/io.js:cluster-remove-unused-argCopy head branch name to clipboard
Closed
cluster: remove unused backlog argument#8877mscdex wants to merge 1 commit intonodejs:masternodejs/node:masterfrom mscdex:cluster-remove-unused-argmscdex/io.js:cluster-remove-unused-argCopy head branch name to clipboard
mscdex wants to merge 1 commit into
nodejs:masternodejs/node:masterfrom
mscdex:cluster-remove-unused-argmscdex/io.js:cluster-remove-unused-argCopy head branch name to clipboard
Conversation
bnoordhuis
approved these changes
Oct 1, 2016
cjihrig
approved these changes
Oct 1, 2016
santigimeno
approved these changes
Oct 3, 2016
fhinkel
approved these changes
Oct 3, 2016
Member
|
Thanks! Landed in 9eb6179. |
fhinkel
pushed a commit
that referenced
this pull request
Oct 3, 2016
PR-URL: #8877 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
PR-URL: #8877 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8877 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Removes an unused backlog argument.
CI: https://ci.nodejs.org/job/node-test-pull-request/4345/
EDIT: CI is green except for a flaky test.