Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

src: swap dotenv and config file parsing order#63035

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
marco-ippolito:swap-env-from-file-configmarco-ippolito/node:swap-env-from-file-configCopy head branch name to clipboard
May 4, 2026
Merged

src: swap dotenv and config file parsing order#63035
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
marco-ippolito:swap-env-from-file-configmarco-ippolito/node:swap-env-from-file-configCopy head branch name to clipboard

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented Apr 29, 2026

Copy link
Copy Markdown
Member

Makes more sense that env variable override config file and not the opposite

@marco-ippolito
src: swap dotenv and config file parsing order
e7ed568 
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Apr 29, 2026
@codecov

codecov Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.63%. Comparing base (8173251) to head (e7ed568).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #63035      +/-   ##
==========================================
- Coverage   91.49%   89.63%   -1.86%     
==========================================
  Files         358      708     +350     
  Lines      151574   220375   +68801     
  Branches    23921    42270   +18349     
==========================================
+ Hits       138679   197539   +58860     
- Misses      12619    14713    +2094     
- Partials      276     8123    +7847
Files with missing lines Coverage Δ
src/node.cc 76.15% <100.00%> (ø)
src/node_dotenv.cc 84.72% <100.00%> (ø)

... and 469 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2026
@nodejs-github-bot

nodejs-github-bot commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73022/

mcollina
mcollina approved these changes Apr 30, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2026
@nodejs-github-bot nodejs-github-bot merged commit 59272da into nodejs:main May 4, 2026
87 of 88 checks passed
@nodejs-github-bot

nodejs-github-bot commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Landed in 59272da

aduh95 pushed a commit that referenced this pull request May 5, 2026
@marco-ippolito @aduh95
src: swap dotenv and config file parsing order
59860eb 
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #63035
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@aduh95 aduh95 mentioned this pull request May 5, 2026
Merged
aduh95 pushed a commit that referenced this pull request May 7, 2026
@marco-ippolito @aduh95
src: swap dotenv and config file parsing order
99bb02f 
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #63035
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@github-actions github-actions Bot mentioned this pull request May 12, 2026
Merged
araujogui pushed a commit to araujogui/node that referenced this pull request May 26, 2026
@marco-ippolito @araujogui
src: swap dotenv and config file parsing order
bd52bbf 
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#63035
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marco-ippolito @nodejs-github-bot @mcollina @Ethan-Arrowood
Morty Proxy This is a proxified and sanitized view of the page, visit original site.