lib: simplify codedTypeError signature#62998
Closed
aduh95 wants to merge 1 commit into
Closed
lib: simplify codedTypeError signature#62998aduh95 wants to merge 1 commit into
codedTypeError signature#62998aduh95 wants to merge 1 commit into
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Member
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62998 +/- ##
==========================================
+ Coverage 89.64% 89.65% +0.01%
==========================================
Files 707 707
Lines 219509 219508 -1
Branches 42095 42085 -10
==========================================
+ Hits 196775 196806 +31
+ Misses 14628 14591 -37
- Partials 8106 8111 +5
🚀 New features to boost your workflow:
|
Contributor
Author
|
@panva should I cherry-pick it and push to your branch? |
Member
|
@aduh95 already did |
Contributor
Author
|
Superseded by 6199f7f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given its name and its usage, it makes little sense to have the function take an optional bag of option when we expect exactly one.