src: make node.config.json throw at unknown fields#62992
src: make node.config.json throw at unknown fields#62992nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom marco-ippolito:sanitize-config-filemarco-ippolito/node:sanitize-config-fileCopy head branch name to clipboard
Conversation
|
Review requested:
|
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
2ee238a to
8923655
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62992 +/- ##
==========================================
+ Coverage 89.63% 89.66% +0.03%
==========================================
Files 706 707 +1
Lines 219219 219512 +293
Branches 42004 42088 +84
==========================================
+ Hits 196499 196832 +333
+ Misses 14622 14581 -41
- Partials 8098 8099 +1
🚀 New features to boost your workflow:
|
|
won't this mean that you can't make a config file that supports multiple versions of node and gracefully uses features from the newer ones when available? |
Yes but also means if you mispell a configuration you will know. I prefer correctness over convenience. |
|
It's not just about convenience, though - it's about being able to support multiple node versions at one time, which also makes upgrading easier (and not supporting that makes upgrading harder). I very much prioritize correctness, but having a closed config every time is highly likely to hold back the ecosystem. |
|
The support for multiple versions of node in the same configuration was never planned and should be discouraged. The $schema needs to match with version being used. I think a possible solution to this problem would be support an array of configurations and node can pick the right one based on version. This plus the ability to extend (like tsconfig) |
|
Landed in 5d578c5 |
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: #62992 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: nodejs#62992 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
The documentation is correct but the implementation was not